Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: @next/third-parties peer dependency #71711

Closed
wants to merge 2 commits into from

Conversation

DeepakBalaraman
Copy link
Contributor

Fixes the upstream dependency conflict caused due to the outdated react peer dependency requirements for @next/third-parties v15.0.1. The following error message when trying to upgrade next 15 is fixed in this PR.

Upgrading your project to Next.js 15.0.1...

npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error While resolving: cinevisualstudios@0.1.0
npm error Found: react@19.0.0-rc-69d4b800-20241021
npm error node_modules/react
npm error   react@"19.0.0-rc-69d4b800-20241021" from the root project
npm error   peer react@"^18.2.0 || 19.0.0-rc-69d4b800-20241021" from next@15.0.1
npm error   node_modules/next
npm error     next@"15.0.1" from the root project
npm error     peer next@"^13.0.0 || ^14.0.0 || ^15.0.0" from @next/third-parties@15.0.1
npm error     node_modules/@next/third-parties
npm error       @next/third-parties@"15.0.1" from the root project
npm error   1 more (react-dom)
npm error
npm error Could not resolve dependency:
npm error peer react@"^18.2.0 || 19.0.0-rc-65a56d0e-20241020" from @next/third-parties@15.0.1
npm error node_modules/@next/third-parties
npm error   @next/third-parties@"15.0.1" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error C:\Users\Deepak B\AppData\Local\npm-cache\_logs\2024-10-23T09_20_58_010Z-eresolve-report.txt
npm error A complete log of this run can be found in: C:\Users\Deepak B\AppData\Local\npm-cache\_logs\2024-10-23T09_20_58_010Z-debug-0.log
Error: Failed to install dependencies
    at runInstallation (C:\Users\Deepak B\AppData\Local\npm-cache\_npx\6a090669e21b4303\node_modules\@next\codemod\lib\handle-package.js:97:15)
    at runUpgrade (C:\Users\Deepak B\AppData\Local\npm-cache\_npx\6a090669e21b4303\node_modules\@next\codemod\bin\upgrade.js:259:42)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async Command.<anonymous> (C:\Users\Deepak B\AppData\Local\npm-cache\_npx\6a090669e21b4303\node_modules\@next\codemod\bin\next-codemod.js:51:9) {
  [cause]: Error: Command failed with exit code 1: npm install
      at makeError (C:\Users\Deepak B\AppData\Local\npm-cache\_npx\6a090669e21b4303\node_modules\execa\lib\error.js:59:11)
      at module.exports.sync (C:\Users\Deepak B\AppData\Local\npm-cache\_npx\6a090669e21b4303\node_modules\execa\index.js:188:17)
      at runInstallation (C:\Users\Deepak B\AppData\Local\npm-cache\_npx\6a090669e21b4303\node_modules\@next\codemod\lib\handle-package.js:91:25)
      at runUpgrade (C:\Users\Deepak B\AppData\Local\npm-cache\_npx\6a090669e21b4303\node_modules\@next\codemod\bin\upgrade.js:259:42)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
      at async Command.<anonymous> (C:\Users\Deepak B\AppData\Local\npm-cache\_npx\6a090669e21b4303\node_modules\@next\codemod\bin\next-codemod.js:51:9) {
    shortMessage: 'Command failed with exit code 1: npm install',
    command: 'npm install',
    exitCode: 1,
    signal: undefined,
    signalDescription: undefined,
    stdout: undefined,
    stderr: undefined,
    failed: true,
    timedOut: false,
    isCanceled: false,
    killed: false
  }
}

Fixes the upstream dependency conflict caused by @next/third-parties package v15.0.1
@ijjk
Copy link
Member

ijjk commented Oct 23, 2024

Allow CI Workflow Run

  • approve CI run for commit: 9dc853c

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@DeepakBalaraman DeepakBalaraman deleted the patch-2 branch October 24, 2024 09:53
@github-actions github-actions bot added the locked label Nov 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants